Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88970


Change subject: Resizeable node updates context after mouse up
......................................................................

Resizeable node updates context after mouse up

Was previously calling show(), which showed the context regardless
of whether one was required or not. Changed this to update().

Change-Id: I2c6c37b6b988cca60f3f3f2429476ab4b429184b
---
M modules/ve/ce/ve.ce.ResizableNode.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/70/88970/1

diff --git a/modules/ve/ce/ve.ce.ResizableNode.js 
b/modules/ve/ce/ve.ce.ResizableNode.js
index 40371a8..3c40266 100644
--- a/modules/ve/ce/ve.ce.ResizableNode.js
+++ b/modules/ve/ce/ve.ce.ResizableNode.js
@@ -290,9 +290,9 @@
                );
        }
 
-       // Show the context menu. This usually happens with the redraw, but not 
if the
+       // Update the context menu. This usually happens with the redraw, but 
not if the
        // user doesn't perform a drag
-       this.root.getSurface().getSurface().getContext().show();
+       this.root.getSurface().getSurface().getContext().update();
 
        this.emit( 'resize' );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/88970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c6c37b6b988cca60f3f3f2429476ab4b429184b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to