[MediaWiki-commits] [Gerrit] Rename method to match interface name - change (mediawiki...WikibaseQueryEngine)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88975


Change subject: Rename method to match interface name
......................................................................

Rename method to match interface name

Change-Id: Idbcf972c60f0346f9ec642394b3f77e401e6ae04
---
M src/QueryStore.php
M src/SQLStore/Store.php
M tests/integration/SQLStore/Engine/DescriptionMatchFinderIntegrationTest.php
M tests/integration/SQLStore/WritingIntegrationTest.php
M tests/phpunit/SQLStore/StoreTest.php
5 files changed, 12 insertions(+), 12 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQueryEngine 
refs/changes/75/88975/1

diff --git a/src/QueryStore.php b/src/QueryStore.php
index 1bd2125..f03162f 100644
--- a/src/QueryStore.php
+++ b/src/QueryStore.php
@@ -51,7 +51,7 @@
         *
         * @return QueryStoreWriter
         */
-       public function getUpdater();
+       public function getWriter();
 
        /**
         * Sets up the store.
diff --git a/src/SQLStore/Store.php b/src/SQLStore/Store.php
index 5d31564..0cf8fb3 100644
--- a/src/SQLStore/Store.php
+++ b/src/SQLStore/Store.php
@@ -80,13 +80,13 @@
        }
 
        /**
-        * @see QueryStore::getUpdater
+        * @see QueryStore::getWriter
         *
         * @since 0.1
         *
         * @return QueryStoreWriter
         */
-       public function getUpdater() {
+       public function getWriter() {
                return $this->factory->newWriter();
        }
 
diff --git 
a/tests/integration/SQLStore/Engine/DescriptionMatchFinderIntegrationTest.php 
b/tests/integration/SQLStore/Engine/DescriptionMatchFinderIntegrationTest.php
index 955148c..5e0ecce 100644
--- 
a/tests/integration/SQLStore/Engine/DescriptionMatchFinderIntegrationTest.php
+++ 
b/tests/integration/SQLStore/Engine/DescriptionMatchFinderIntegrationTest.php
@@ -105,7 +105,7 @@
                $claim->setGuid( 'claim0' );
                $item->addClaim( $claim );
 
-               $this->store->getUpdater()->insertEntity( $item );
+               $this->store->getWriter()->insertEntity( $item );
 
 
                $item = Item::newEmpty();
@@ -115,7 +115,7 @@
                $claim->setGuid( 'claim1' );
                $item->addClaim( $claim );
 
-               $this->store->getUpdater()->insertEntity( $item );
+               $this->store->getWriter()->insertEntity( $item );
 
 
                $item = Item::newEmpty();
@@ -125,7 +125,7 @@
                $claim->setGuid( 'claim2' );
                $item->addClaim( $claim );
 
-               $this->store->getUpdater()->insertEntity( $item );
+               $this->store->getWriter()->insertEntity( $item );
 
 
                $item = Item::newEmpty();
@@ -139,7 +139,7 @@
                $claim->setGuid( 'claim4' );
                $item->addClaim( $claim );
 
-               $this->store->getUpdater()->insertEntity( $item );
+               $this->store->getWriter()->insertEntity( $item );
        }
 
        /**
diff --git a/tests/integration/SQLStore/WritingIntegrationTest.php 
b/tests/integration/SQLStore/WritingIntegrationTest.php
index 73fe6ec..7ef0ecd 100644
--- a/tests/integration/SQLStore/WritingIntegrationTest.php
+++ b/tests/integration/SQLStore/WritingIntegrationTest.php
@@ -112,7 +112,7 @@
                $claim->setGuid( 'a claim' );
                $item->addClaim( $claim );
 
-               $this->store->getUpdater()->insertEntity( $item );
+               $this->store->getWriter()->insertEntity( $item );
 
                $propertyDescription = new SomeProperty(
                        new EntityIdValue( new PropertyId( 'P42' ) ),
@@ -124,7 +124,7 @@
                        $this->findMatchingEntities( $propertyDescription )
                );
 
-               $this->store->getUpdater()->deleteEntity( $item );
+               $this->store->getWriter()->deleteEntity( $item );
 
                $this->assertEquals(
                        array(),
@@ -155,7 +155,7 @@
                $claim->setGuid( 'foo claim' );
                $item->addClaim( $claim );
 
-               $this->store->getUpdater()->insertEntity( $item );
+               $this->store->getWriter()->insertEntity( $item );
 
                $claim = new Statement( new PropertyValueSnak( 42, new 
StringValue( 'Foo' ) ) );
                $claim->setGuid( 'bar claim' );
@@ -164,7 +164,7 @@
                        $claim
                ) ) );
 
-               $this->store->getUpdater()->updateEntity( $item );
+               $this->store->getWriter()->updateEntity( $item );
 
                $propertyDescription = new SomeProperty(
                        new EntityIdValue( new PropertyId( 'P42' ) ),
diff --git a/tests/phpunit/SQLStore/StoreTest.php 
b/tests/phpunit/SQLStore/StoreTest.php
index 94c574a..4e6dc44 100644
--- a/tests/phpunit/SQLStore/StoreTest.php
+++ b/tests/phpunit/SQLStore/StoreTest.php
@@ -48,7 +48,7 @@
        public function testGetUpdaterReturnType() {
                $this->assertInstanceOf(
                        'Wikibase\QueryEngine\QueryStoreWriter',
-                       $this->newInstance()->getUpdater()
+                       $this->newInstance()->getWriter()
                );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbcf972c60f0346f9ec642394b3f77e401e6ae04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQueryEngine
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits