Daniel Werner has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89041


Change subject: Fix for rare failure in case of no farm members defined
......................................................................

Fix for rare failure in case of no farm members defined

Change-Id: I088569ce8f56ee1a6addee6ed4cf7f51857c2871
---
M includes/SimpleFarm.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SimpleFarm 
refs/changes/41/89041/1

diff --git a/includes/SimpleFarm.php b/includes/SimpleFarm.php
index 17fdf57..3e10723 100644
--- a/includes/SimpleFarm.php
+++ b/includes/SimpleFarm.php
@@ -159,10 +159,12 @@
 
                global $egSimpleFarmMainMemberDB, $wgCommandLineMode;
 
+               $mainMember = self::getMainMember();
+
                // set some main member if not set in config and farm has 
members:
-               if( $egSimpleFarmMainMemberDB === null ) {
-                       $egSimpleFarmMainMemberDB = 
self::getMainMember()->getDB();
-               }               
+               if( $egSimpleFarmMainMemberDB === null && $mainMember !== null 
) {
+                       $egSimpleFarmMainMemberDB = $mainMember->getDB();
+               }
                // get selected member for this farm call:
                $wiki = self::getActiveMember();
                

-- 
To view, visit https://gerrit.wikimedia.org/r/89041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I088569ce8f56ee1a6addee6ed4cf7f51857c2871
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SimpleFarm
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to