Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/89156
Change subject: Add an explicit targets declaration for mediawiki.inspect
......................................................................
Add an explicit targets declaration for mediawiki.inspect
Jon Robson indicating he'd be interested in making mediawiki.inspect usable on
the mobile site by specifying both mobile & desktop targets explicitly in the
resource declaration. That's what this patch does. The cost to this is very
minimal because the module is never loaded by default. mw.loader.inspect()
wraps the call to the inspector with an mw.loader.using() call that causes the
module to be retrieved. It is not retrieved otherwise.
Change-Id: I7cf292d3b8fb554bd1fc2143ca45399efccb70aa
---
M resources/Resources.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/56/89156/1
diff --git a/resources/Resources.php b/resources/Resources.php
index 050e933..16764d1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -649,6 +649,7 @@
'mediawiki.inspect' => array(
'scripts' => 'resources/mediawiki/mediawiki.inspect.js',
'dependencies' => 'jquery.byteLength',
+ 'targets' => array( 'desktop', 'mobile' ),
),
'mediawiki.feedback' => array(
'scripts' => 'resources/mediawiki/mediawiki.feedback.js',
--
To view, visit https://gerrit.wikimedia.org/r/89156
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cf292d3b8fb554bd1fc2143ca45399efccb70aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
