jenkins-bot has submitted this change and it was merged.

Change subject: Add more docs on XDebug, and fix hostname
......................................................................


Add more docs on XDebug, and fix hostname

Change-Id: I7a0bdd295521c153f5127974936f910177b14a03
---
M puppet/manifests/roles.pp
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/manifests/roles.pp b/puppet/manifests/roles.pp
index e4f968b..f74f99b 100644
--- a/puppet/manifests/roles.pp
+++ b/puppet/manifests/roles.pp
@@ -363,18 +363,20 @@
 # This class enables support for remote debugging of PHP code using
 # Xdebug. Remote debugging allows you to interactively walk through your
 # code as executes. Remote debugging is most useful when used in
-# conjunction with a PHP IDE such as PhpStorm. The IDE is installed on
-# your machine, not the Vagrant VM.
+# conjunction with a PHP IDE such as PhpStorm or Emacs (with Geben).
+# The IDE is installed on your machine, not the Vagrant VM.
 #
 # -- To use, enable this role from shell:
 #    vagrant enable-role remote_debug
 # -- In your IDE, enable "Start Listening for PHP Debug Connections"
-# -- For firefox, install
+# -- For Firefox, install
 #    https://addons.mozilla.org/en-US/firefox/addon/the-easiest-xdebug
 #    and click "Enable Debug" icon in the Add-on bar
 # -- Set breakpoints
-# -- Navigate to localhost:8080/...
+# -- Navigate to 127.0.0.1:8080/...
 #
+# See 
https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Advanced_usage#MediaWiki_debugging_using_Xdebug_and_an_IDE_in_your_host
+# for more information.
 class role::remote_debug {
     include php
 

-- 
To view, visit https://gerrit.wikimedia.org/r/89151
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0bdd295521c153f5127974936f910177b14a03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to