Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/89198
Change subject: Remove ve.ce.ImageNode.prototype.on{Click,Update}
......................................................................
Remove ve.ce.ImageNode.prototype.on{Click,Update}
onUpdate was empty, onClick was unnecessary because FocusableNode and
ProtectedNode are already mixed in.
Change-Id: Idd0592d6f30388c9952e110ff6fff008bb465877
---
M modules/ve/ce/nodes/ve.ce.ImageNode.js
1 file changed, 0 insertions(+), 32 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/98/89198/1
diff --git a/modules/ve/ce/nodes/ve.ce.ImageNode.js
b/modules/ve/ce/nodes/ve.ce.ImageNode.js
index bd0f58a..3396597 100644
--- a/modules/ve/ce/nodes/ve.ce.ImageNode.js
+++ b/modules/ve/ce/nodes/ve.ce.ImageNode.js
@@ -30,10 +30,6 @@
// Properties
this.$image = this.$;
- // Events
- this.model.connect( this, { 'update': 'onUpdate' } );
- this.$.on( 'click', ve.bind( this.onClick, this ) );
-
// Initialization
this.$image
.addClass( 've-ce-imageNode' )
@@ -81,34 +77,6 @@
this.$image.css( key, to );
}
}
-};
-
-/**
- * Update method
- *
- * @method
- */
-ve.ce.ImageNode.prototype.onUpdate = function () {
-};
-
-/**
- * Handle the mouse click.
- *
- * @method
- * @param {jQuery.Event} e Click event
- */
-ve.ce.ImageNode.prototype.onClick = function ( e ) {
- var surfaceModel = this.getRoot().getSurface().getModel(),
- selectionRange = surfaceModel.getSelection(),
- nodeRange = this.model.getOuterRange();
-
- surfaceModel.getFragment(
- e.shiftKey ?
- ve.Range.newCoveringRange(
- [ selectionRange, nodeRange ],
selectionRange.from > nodeRange.from
- ) :
- nodeRange
- ).select();
};
/* Registration */
--
To view, visit https://gerrit.wikimedia.org/r/89198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd0592d6f30388c9952e110ff6fff008bb465877
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
