Mdale has submitted this change and it was merged.
Change subject: Correct mw.PopUpMediaTransform dependency
......................................................................
Correct mw.PopUpMediaTransform dependency
mw.PopUpMediaTransform actually only has a direct depdendency on
mw.MwEmbedSupport, which provides mw.addDialog. This makes a
difference since mw.MwEmbedSupport only loads jquery.ui.dialog
dynamically if an actual dialog is shown.
Bug: 55550
Change-Id: I578c93c3036b661f6e4fea9723212e0b9b7b216f
---
M TimedMediaHandler.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mdale: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index a681a54..994b9dc 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -60,7 +60,7 @@
'mw.PopUpMediaTransform' => array_merge(
$baseExtensionResource, array(
'scripts' => 'resources/mw.PopUpThumbVideo.js',
'styles' => 'resources/PopUpThumbVideo.css',
- 'dependencies' => array( 'jquery.ui.dialog' ),
+ 'dependencies' => array( 'mw.MwEmbedSupport' ),
) ),
'mw.TMHGalleryHook.js' => array_merge(
$baseExtensionResource, array(
'scripts' => 'resources/mw.TMHGalleryHook.js',
--
To view, visit https://gerrit.wikimedia.org/r/88944
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I578c93c3036b661f6e4fea9723212e0b9b7b216f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Mdale <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
