jenkins-bot has submitted this change and it was merged.
Change subject: Only run setrank tests if experimental is on
......................................................................
Only run setrank tests if experimental is on
if Experimental is off these tests will always fail
Change-Id: Id05a6ff8bcc9908f8b618551d79a67475bebbe53
---
M repo/tests/phpunit/includes/api/SetStatementRankTest.php
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/api/SetStatementRankTest.php
b/repo/tests/phpunit/includes/api/SetStatementRankTest.php
index 1593b7c..478aa47 100644
--- a/repo/tests/phpunit/includes/api/SetStatementRankTest.php
+++ b/repo/tests/phpunit/includes/api/SetStatementRankTest.php
@@ -88,6 +88,11 @@
}
public function testRequests() {
+ //TODO REMOVE ONCE ENABLED
+ if ( !defined( 'WB_EXPERIMENTAL_FEATURES' ) ||
!WB_EXPERIMENTAL_FEATURES ) {
+ $this->markTestSkipped( 'WB_EXPERIMENTAL_FEATURES are
not enabled so this module is not enabled..' );
+ }
+
$ranks = ClaimSerializer::getRanks();
foreach ( $this->statementProvider() as $statement ) {
@@ -202,6 +207,11 @@
* @dataProvider invalidClaimProvider
*/
public function testInvalidClaimGuid( $claimGuid ) {
+ //TODO REMOVE ONCE ENABLED
+ if ( !defined( 'WB_EXPERIMENTAL_FEATURES' ) ||
!WB_EXPERIMENTAL_FEATURES ) {
+ $this->markTestSkipped( 'WB_EXPERIMENTAL_FEATURES are
not enabled so this module is not enabled..' );
+ }
+
$ranks = ClaimSerializer::getRanks();
$params = array(
--
To view, visit https://gerrit.wikimedia.org/r/89176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id05a6ff8bcc9908f8b618551d79a67475bebbe53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
