MaxSem has uploaded a new change for review.
https://gerrit.wikimedia.org/r/89229
Change subject: Blacklist Nokia's Ovi Browser from ResourceLoader
......................................................................
Blacklist Nokia's Ovi Browser from ResourceLoader
It runs scripts proxy-side much like Opera Mini does, resulting in nothing
resembling a real JS engine. This causes problems and the browser is popular
enough to warrant a block.
Change-Id: I2c1ee78828c2b9cead4f82ef795972a4c28140b4
---
M resources/startup.js
M tests/qunit/suites/resources/startup.test.js
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/29/89229/1
diff --git a/resources/startup.js b/resources/startup.js
index 6fa8b3c..b6a27d2 100644
--- a/resources/startup.js
+++ b/resources/startup.js
@@ -39,7 +39,9 @@
// Any NetFront based browser
ua.match( /NetFront/ ) ||
// Opera Mini, all versions
- ua.match( /Opera Mini/ )
+ ua.match( /Opera Mini/ ) ||
+ // Nokia's Ovi Browser
+ ua.match( /S40OviBrowser/ )
);
}
diff --git a/tests/qunit/suites/resources/startup.test.js
b/tests/qunit/suites/resources/startup.test.js
index 57825c5..76f32f7 100644
--- a/tests/qunit/suites/resources/startup.test.js
+++ b/tests/qunit/suites/resources/startup.test.js
@@ -68,7 +68,10 @@
'Opera/9.80 (J2ME/MIDP; Opera Mini/3.1.10423/22.387; U;
en) Presto/2.5.25 Version/10.54',
'Opera/9.50 (J2ME/MIDP; Opera Mini/4.0.10031/298; U;
en)',
'Opera/9.80 (J2ME/MIDP; Opera Mini/6.24093/26.1305; U;
en) Presto/2.8.119 Version/10.54',
- 'Opera/9.80 (Android; Opera Mini/7.29530/27.1407; U;
en) Presto/2.8.119 Version/11.10'
+ 'Opera/9.80 (Android; Opera Mini/7.29530/27.1407; U;
en) Presto/2.8.119 Version/11.10',
+ // Ovi Browser
+ 'Mozilla/5.0 (Series40; NokiaX3-02/05.60;
Profile/MIDP-2.1 Configuration/CLDC-1.1) Gecko/20100401
S40OviBrowser/3.2.0.0.6',
+ 'Mozilla/5.0 (Series40; Nokia305/05.92;
Profile/MIDP-2.1 Configuration/CLDC-1.1) Gecko/20100401
S40OviBrowser/3.7.0.0.11'
],
// No explicit support for or against these browsers, they're
// given a shot at Grade A at their own risk.
--
To view, visit https://gerrit.wikimedia.org/r/89229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c1ee78828c2b9cead4f82ef795972a4c28140b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
