jenkins-bot has submitted this change and it was merged. Change subject: Add an explicit targets declaration for mediawiki.inspect & $.byteLength ......................................................................
Add an explicit targets declaration for mediawiki.inspect & $.byteLength Jon Robson said[1] he'd be interested in making mediawiki.inspect usable on the mobile site by specifying both mobile & desktop targets explicitly in the resource declaration. That's what this patch does. The cost to this is very minimal because the module is never loaded by default. mw.loader.inspect() wraps the call to the inspector with an mw.loader.using() call that causes the module to be retrieved. It is not retrieved otherwise. [1]: http://lists.wikimedia.org/pipermail/wikitech-l/2013-October/072381.html Change-Id: I7cf292d3b8fb554bd1fc2143ca45399efccb70aa --- M resources/Resources.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/Resources.php b/resources/Resources.php index 050e933..6f4b9f7 100644 --- a/resources/Resources.php +++ b/resources/Resources.php @@ -160,6 +160,7 @@ ), 'jquery.byteLength' => array( 'scripts' => 'resources/jquery/jquery.byteLength.js', + 'targets' => array( 'desktop', 'mobile' ), ), 'jquery.byteLimit' => array( 'scripts' => 'resources/jquery/jquery.byteLimit.js', @@ -649,6 +650,7 @@ 'mediawiki.inspect' => array( 'scripts' => 'resources/mediawiki/mediawiki.inspect.js', 'dependencies' => 'jquery.byteLength', + 'targets' => array( 'desktop', 'mobile' ), ), 'mediawiki.feedback' => array( 'scripts' => 'resources/mediawiki/mediawiki.feedback.js', -- To view, visit https://gerrit.wikimedia.org/r/89156 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cf292d3b8fb554bd1fc2143ca45399efccb70aa Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
