jenkins-bot has submitted this change and it was merged.
Change subject: (hotfix) SiteLinksEditTool: Address correct scope
......................................................................
(hotfix) SiteLinksEditTool: Address correct scope
Change-Id: I34ea881422212bb2b0f30bfaaf481a230e029678
---
M lib/resources/wikibase.ui.SiteLinksEditTool.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/wikibase.ui.SiteLinksEditTool.js
b/lib/resources/wikibase.ui.SiteLinksEditTool.js
index 94615b0..97694ad 100644
--- a/lib/resources/wikibase.ui.SiteLinksEditTool.js
+++ b/lib/resources/wikibase.ui.SiteLinksEditTool.js
@@ -135,6 +135,8 @@
* @return {wb.ui.PropertyEditTool.EditableValue}
*/
enterNewValue: function( value ) {
+ var self = this;
+
this._initializeSiteLinksTableHeader();
// Have the editableValues prototype regenerated each time a
new value is about to be
@@ -148,7 +150,8 @@
$( newValue ).on( 'afterStopEditing', function( event, save,
wasPending ) {
if ( save ) {
- var $siteLinksTable = this._subject;
+ var $siteLinksTable = self._subject;
+
// move appended site link into the table body
to have it included in sorting
this.getSubject().appendTo(
$siteLinksTable.children( 'tbody' ) );
--
To view, visit https://gerrit.wikimedia.org/r/89232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34ea881422212bb2b0f30bfaaf481a230e029678
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
