jenkins-bot has submitted this change and it was merged.
Change subject: Remove ve.ce.ImageNode.prototype.onUpdate
......................................................................
Remove ve.ce.ImageNode.prototype.onUpdate
Was empty.
Bonus: consistently use object style for .attr(), was already
used for .css()
Change-Id: Idd0592d6f30388c9952e110ff6fff008bb465877
---
M modules/ve/ce/nodes/ve.ce.ImageNode.js
1 file changed, 4 insertions(+), 11 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/nodes/ve.ce.ImageNode.js
b/modules/ve/ce/nodes/ve.ce.ImageNode.js
index bd0f58a..539e02b 100644
--- a/modules/ve/ce/nodes/ve.ce.ImageNode.js
+++ b/modules/ve/ce/nodes/ve.ce.ImageNode.js
@@ -31,14 +31,15 @@
this.$image = this.$;
// Events
- this.model.connect( this, { 'update': 'onUpdate' } );
this.$.on( 'click', ve.bind( this.onClick, this ) );
// Initialization
this.$image
.addClass( 've-ce-imageNode' )
- .attr( 'alt', this.model.getAttribute( 'alt' ) )
- .attr( 'src', this.model.getAttribute( 'src' ) )
+ .attr( {
+ 'alt': this.model.getAttribute( 'alt' ),
+ 'src': this.model.getAttribute( 'src' )
+ } )
.css( {
'width': this.model.getAttribute( 'width' ),
'height': this.model.getAttribute( 'height' )
@@ -81,14 +82,6 @@
this.$image.css( key, to );
}
}
-};
-
-/**
- * Update method
- *
- * @method
- */
-ve.ce.ImageNode.prototype.onUpdate = function () {
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/89198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd0592d6f30388c9952e110ff6fff008bb465877
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
