jenkins-bot has submitted this change and it was merged. Change subject: Revert visibility change to HTMLForm $typeMappings ......................................................................
Revert visibility change to HTMLForm $typeMappings Change Id5668141835e22e3e1b043109e50d73ccd6b1229 changed the visibility of static $typeMappings to private. It turns out this breaks http://www.blue-spice.org/ who want to add their own HTMLForm types and have no way to extend or override this except by changing it. So set it to public static. As https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP says, "It's generally a good idea to avoid visibility changes unless you're making changes to the function which would break old uses of it anyway." That trumps PHP CodeSniffer warnings. Change-Id: Ife82596e96a4650b977422aae6b32f24a392d5fb --- M includes/HTMLForm.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alex Monk: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/HTMLForm.php b/includes/HTMLForm.php index 5de34d6..70dc7c7 100644 --- a/includes/HTMLForm.php +++ b/includes/HTMLForm.php @@ -94,7 +94,7 @@ class HTMLForm extends ContextSource { // A mapping of 'type' inputs onto standard HTMLFormField subclasses - private static $typeMappings = array( + public static $typeMappings = array( 'api' => 'HTMLApiField', 'text' => 'HTMLTextField', 'textarea' => 'HTMLTextAreaField', -- To view, visit https://gerrit.wikimedia.org/r/89391 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife82596e96a4650b977422aae6b32f24a392d5fb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Alex Monk <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Smuggli <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
