jenkins-bot has submitted this change and it was merged.
Change subject: Native digits on 'mw-echo-overlay-title-text'
......................................................................
Native digits on 'mw-echo-overlay-title-text'
Change-Id: Icdd52ea0267ffbaa0e103070655735eff8423ca1
---
M Echo.php
M modules/overlay/ext.echo.overlay.js
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Echo.php b/Echo.php
index d4777f5..ced1f47 100644
--- a/Echo.php
+++ b/Echo.php
@@ -174,6 +174,7 @@
'dependencies' => array(
'ext.echo.desktop',
'mediawiki.util',
+ 'mediawiki.language',
),
'messages' => array(
'echo-overlay-title',
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index 55ddda8..eaa6e22 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -123,7 +123,11 @@
if ( notifications.index.length > 0 ) {
if ( unreadRawTotalCount >
unread.length ) {
- titleText = mw.msg(
'echo-overlay-title-overflow', unread.length, unreadTotalCount );
+ titleText = mw.msg(
+
'echo-overlay-title-overflow',
+
mw.language.convertNumber( unread.length ),
+
mw.language.convertNumber( unreadTotalCount )
+ );
overflow = true;
} else {
titleText = mw.msg(
'echo-overlay-title' );
--
To view, visit https://gerrit.wikimedia.org/r/88045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdd52ea0267ffbaa0e103070655735eff8423ca1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Ebrahim <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Reza <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
