Jeroen De Dauw has submitted this change and it was merged.
Change subject: Use constants in FieldDefinition constructor
......................................................................
Use constants in FieldDefinition constructor
Change-Id: I004c7bd0f524aa7b87ff82d80e98fd19e630b537
---
M src/Schema/Definitions/FieldDefinition.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/src/Schema/Definitions/FieldDefinition.php
b/src/Schema/Definitions/FieldDefinition.php
index 0864dc7..18c5bdb 100644
--- a/src/Schema/Definitions/FieldDefinition.php
+++ b/src/Schema/Definitions/FieldDefinition.php
@@ -84,7 +84,7 @@
*
* @throws InvalidArgumentException
*/
- public function __construct( $name, $type, $null = self::NULL, $default
= self::NO_DEFAULT, $attributes = null, $autoIncrement = false ) {
+ public function __construct( $name, $type, $null = self::NULL, $default
= self::NO_DEFAULT, $attributes = self::NO_ATTRIB, $autoIncrement =
self::NO_AUTOINCREMENT ) {
$this->assertIsValidName( $name );
$this->assertIsValidType( $type );
$this->assertIsValudNull( $null );
--
To view, visit https://gerrit.wikimedia.org/r/89525
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I004c7bd0f524aa7b87ff82d80e98fd19e630b537
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
