Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/89630
Change subject: Prefer __DIR__ to $dir
......................................................................
Prefer __DIR__ to $dir
__DIR__ is the more common idiom these days, and there is absolutely no
advantage (in fact, there's a slight performance penalty) to storing it in a
variable.
Change-Id: I20211539ccc17937b141331c1875f219a92b1483
---
M UniversalLanguageSelector.php
1 file changed, 7 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/30/89630/1
diff --git a/UniversalLanguageSelector.php b/UniversalLanguageSelector.php
index 12cae2b..2d570a0 100644
--- a/UniversalLanguageSelector.php
+++ b/UniversalLanguageSelector.php
@@ -137,17 +137,15 @@
*/
$wgULSNoWebfontsSelectors = array( '#p-lang li > a' );
-$dir = __DIR__;
-
// Internationalization
-$wgExtensionMessagesFiles['UniversalLanguageSelector'] =
"$dir/UniversalLanguageSelector.i18n.php";
+$wgExtensionMessagesFiles['UniversalLanguageSelector'] = __DIR__ .
'/UniversalLanguageSelector.i18n.php';
// Register auto load for the page class
-$wgAutoloadClasses['UniversalLanguageSelectorHooks'] =
"$dir/UniversalLanguageSelector.hooks.php";
-$wgAutoloadClasses['ResourceLoaderULSModule'] =
"$dir/ResourceLoaderULSModule.php";
-$wgAutoloadClasses['ApiLanguageSearch'] = "$dir/api/ApiLanguageSearch.php";
-$wgAutoloadClasses['ApiULSLocalization'] = "$dir/api/ApiULSLocalization.php";
-$wgAutoloadClasses['LanguageNameSearch'] = "$dir/data/LanguageNameSearch.php";
+$wgAutoloadClasses['UniversalLanguageSelectorHooks'] = __DIR__ .
'/UniversalLanguageSelector.hooks.php';
+$wgAutoloadClasses['ResourceLoaderULSModule'] = __DIR__ .
'/ResourceLoaderULSModule.php';
+$wgAutoloadClasses['ApiLanguageSearch'] = __DIR__ .
'/api/ApiLanguageSearch.php';
+$wgAutoloadClasses['ApiULSLocalization'] = __DIR__ .
'/api/ApiULSLocalization.php';
+$wgAutoloadClasses['LanguageNameSearch'] = __DIR__ .
'/data/LanguageNameSearch.php';
$wgHooks['BeforePageDisplay'][] = 'UniversalLanguageSelectorHooks::addModules';
$wgHooks['PersonalUrls'][] =
'UniversalLanguageSelectorHooks::addPersonalBarTrigger';
@@ -196,4 +194,4 @@
return true;
};
-require "$dir/Resources.php";
+require __DIR__ . '/Resources.php";
--
To view, visit https://gerrit.wikimedia.org/r/89630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20211539ccc17937b141331c1875f219a92b1483
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
