jenkins-bot has submitted this change and it was merged. Change subject: Add documentation on SQL format to interfaces ......................................................................
Add documentation on SQL format to interfaces Change-Id: I9a7e26d19e29e1a6f5727b0d8f0b89d0f68c168f --- M src/Schema/SchemaModificationSqlBuilder.php M src/Schema/TableSqlBuilder.php 2 files changed, 9 insertions(+), 10 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/src/Schema/SchemaModificationSqlBuilder.php b/src/Schema/SchemaModificationSqlBuilder.php index c44e0df..5b2d2c5 100644 --- a/src/Schema/SchemaModificationSqlBuilder.php +++ b/src/Schema/SchemaModificationSqlBuilder.php @@ -6,6 +6,11 @@ use Wikibase\Database\Schema\Definitions\IndexDefinition; /** + * The SQL returned by the methods in this interface may contain multiple statements. + * The SQL may also consist out of multiple lines. One statement per line. + * Multiple statements on one line is not allowed, and neither is spreading a + * statement over multiple lines. + * * @since 0.1 * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/src/Schema/TableSqlBuilder.php b/src/Schema/TableSqlBuilder.php index 421cbb6..5aa347d 100644 --- a/src/Schema/TableSqlBuilder.php +++ b/src/Schema/TableSqlBuilder.php @@ -6,16 +6,10 @@ use Wikibase\Database\Schema\Definitions\TableDefinition; /** - * Base database abstraction class to put stuff into that is not present - * in the MW core db abstraction layer. - * - * Like to core class DatabaseBase, each deriving class provides support - * for a specific type of database. - * - * Everything implemented in these classes could go into DatabaseBase and - * deriving classes, though this might take quite some time, hence implementation - * is first done here. If you feel like taking core CR crap and waiting a few - * months, by all means try to get the functionality into core. + * The SQL returned by the methods in this interface may contain multiple statements. + * The SQL may also consist out of multiple lines. One statement per line. + * Multiple statements on one line is not allowed, and neither is spreading a + * statement over multiple lines. * * @since 0.1 * @licence GNU GPL v2+ -- To view, visit https://gerrit.wikimedia.org/r/88715 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a7e26d19e29e1a6f5727b0d8f0b89d0f68c168f Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/WikibaseDatabase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
