Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/89712
Change subject: Expand TableCreateModifyDeleteTest integrationTest
......................................................................
Expand TableCreateModifyDeleteTest integrationTest
Change-Id: Iba9a796ef0777427b4494108be02b3f4771a0a52
---
M tests/integration/MediaWiki/Schema/TableCreateModifyDeleteTest.php
1 file changed, 17 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase
refs/changes/12/89712/1
diff --git a/tests/integration/MediaWiki/Schema/TableCreateModifyDeleteTest.php
b/tests/integration/MediaWiki/Schema/TableCreateModifyDeleteTest.php
index 930b1f5..4490a28 100644
--- a/tests/integration/MediaWiki/Schema/TableCreateModifyDeleteTest.php
+++ b/tests/integration/MediaWiki/Schema/TableCreateModifyDeleteTest.php
@@ -90,19 +90,32 @@
$schemaModifer = $this->newSchemaModifier();
//add a new field
+ /** @var $table TableDefinition */
$newField = new FieldDefinition( 'secondField',
FieldDefinition::TYPE_INTEGER );
$schemaModifer->addField( $table->getName(), $newField );
$table = $table->mutateFields( array_merge(
$table->getFields(), array( $newField ) ) );
$this->assertTable( $tableBuilder, $table, 'assert field added'
);
- //remove a new index
+ //add a new index
+ /** @var $table TableDefinition */
$newIndex = new IndexDefinition( 'indexName', array(
'secondField' => 0 ) );
$schemaModifer->addIndex( $table->getName(), $newIndex );
$table = $table->mutateIndexes( array_merge(
$table->getIndexes(), array( $newIndex ) ) );
$this->assertTable( $tableBuilder, $table, 'assert index added'
);
- //TODO remove and field
- //TODO remove an index
+ //TODO fix the two below tests in sqlite
+// //remove an index
+// /** @var $table TableDefinition */
+// $schemaModifer->removeIndex( $table->getName(),
$newIndex->getName() );
+// $table = $table->mutateIndexAway( $newIndex->getName() );
+// $this->assertTable( $tableBuilder, $table, 'assert index
removed' );
+//
+// //remove a field
+// /** @var $table TableDefinition */
+// $schemaModifer->removeField( $table->getName(),
$newField->getName() );
+// $table = $table->mutateFieldAway( $newField->getName() );
+// $this->assertTable( $tableBuilder, $table, 'assert field
removed' );
+
}
protected function assertTable( TableBuilder $tableBuilder,
TableDefinition $table, $message = '' ){
@@ -116,7 +129,7 @@
$this->assertEquals(
$table,
$tableReader->readDefinition( $table->getName() ),
- $message . '(definitionEquals)'
+ $message . ' (definitionEquals)'
);
}
--
To view, visit https://gerrit.wikimedia.org/r/89712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba9a796ef0777427b4494108be02b3f4771a0a52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
