Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/90071
Change subject: Remove dead search button code
......................................................................
Remove dead search button code
No longer used anywhere
Change-Id: Id1d404d55fb416dea7803b49f8fbae8226ef377b
---
M javascripts/common/Page.js
D javascripts/specials/modules/search-btn.js
2 files changed, 1 insertion(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/71/90071/1
diff --git a/javascripts/common/Page.js b/javascripts/common/Page.js
index 18ee8ca..8b36ae3 100644
--- a/javascripts/common/Page.js
+++ b/javascripts/common/Page.js
@@ -77,7 +77,7 @@
// FIXME: [ajax page loading] Note this will not work when we
ajax load namespaces other than main which we currently do not do.
isTalkPage: function() {
- return mw.config.get( 'wgNamespaceIds' ).talk ===
mw.config.get( 'wgNamespaceNumber' );
+ return M.inNamespace( 'talk' );
},
preRender: function( options ) {
diff --git a/javascripts/specials/modules/search-btn.js
b/javascripts/specials/modules/search-btn.js
deleted file mode 100644
index afb71fe..0000000
--- a/javascripts/specials/modules/search-btn.js
+++ /dev/null
@@ -1,14 +0,0 @@
-( function( M, $ ) {
-
-var search = M.require( 'search' );
-
-if ( mw.config.get( 'wgNamespaceNumber' ) === mw.config.get( 'wgNamespaceIds'
).special &&
- mw.config.get( 'wgCanonicalSpecialPageName' ) !== 'Nearby' ) {// FIXME:
allow nearby to have search & refresh icon
- $( '<a class="search-button">' ).attr( 'href', '#' ).
- on( 'click', function() {
- search.overlay.showAndFocus();
- } ).
- appendTo( '.header' );
-}
-
-}( mw.mobileFrontend, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/90071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1d404d55fb416dea7803b49f8fbae8226ef377b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
