Adamw has submitted this change and it was merged.
Change subject: Campaign log pager: ensure throttle change helper returns a
value
......................................................................
Campaign log pager: ensure throttle change helper returns a value
Change-Id: I950e02c99dbba3e9b13432d4eb98495911b83ae0
---
M CentralNoticeCampaignLogPager.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Adamw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralNoticeCampaignLogPager.php
b/CentralNoticeCampaignLogPager.php
index 3a4e6a6..166d1a0 100644
--- a/CentralNoticeCampaignLogPager.php
+++ b/CentralNoticeCampaignLogPager.php
@@ -423,6 +423,7 @@
protected function testPercentageChange( $param, $row ) {
$beginField = 'notlog_begin_' . $param;
$endField = 'notlog_end_' . $param;
+ $result = '';
if ( $row->$beginField !== $row->$endField ) {
$beginMessage = strval( $row->$beginField ) . '%';
$endMessage = strval( $row->$endField ) . '%';
@@ -436,10 +437,8 @@
$endMessage
)->text()
)->text() . "<br />";
- return $result;
- } else {
- return '';
}
+ return $result;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/90276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I950e02c99dbba3e9b13432d4eb98495911b83ae0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
