Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/90348
Change subject: add test case for UnDeserializableValue in snak formatter
builders
......................................................................
add test case for UnDeserializableValue in snak formatter builders
- also fix assumption about message language
Change-Id: Id516cb2907a6a02570ef0f538d5593c378a8802d
---
M lib/tests/phpunit/formatters/WikibaseSnakFormatterBuildersTest.php
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/48/90348/1
diff --git a/lib/tests/phpunit/formatters/WikibaseSnakFormatterBuildersTest.php
b/lib/tests/phpunit/formatters/WikibaseSnakFormatterBuildersTest.php
index 1a20bbf..8584178 100644
--- a/lib/tests/phpunit/formatters/WikibaseSnakFormatterBuildersTest.php
+++ b/lib/tests/phpunit/formatters/WikibaseSnakFormatterBuildersTest.php
@@ -5,6 +5,7 @@
use DataValues\GlobeCoordinateValue;
use DataValues\StringValue;
use DataValues\TimeValue;
+use DataValues\UnDeserializableValue;
use Language;
use ValueFormatters\FormatterOptions;
use ValueFormatters\ValueFormatter;
@@ -109,6 +110,12 @@
ValueFormatter::OPT_LANG => 'en',
) );
+ $msg = wfMessage( 'wikibase-snakview-snaktypeselector-novalue'
);
+ $noValueMsg = $msg->inLanguage( 'en' )->text();
+
+ $msg = wfMessage( 'wikibase-undeserializable-value' );
+ $badValueMsg = $msg->inLanguage( 'en' )->text();
+
return array(
'plain url' => array(
SnakFormatter::FORMAT_PLAIN,
@@ -122,7 +129,7 @@
$options,
'string',
new PropertyNoValueSnak( 7 ),
- wfMessage(
'wikibase-snakview-snaktypeselector-novalue' )->text()
+ $noValueMsg
),
'html string' => array(
SnakFormatter::FORMAT_HTML,
@@ -138,6 +145,15 @@
new PropertyValueSnak( 7, new EntityIdValue(
new ItemId( 'Q5' ) ) ),
'Label for Q5' // compare mock object created
in newBuilders()
),
+ 'bad value' => array(
+ SnakFormatter::FORMAT_PLAIN,
+ $options,
+ 'globecoordinate',
+ new PropertyValueSnak( 7,
+ new UnDeserializableValue( 'cookie',
'globecoordinate', 'cannot understand!' )
+ ),
+ $badValueMsg
+ )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/90348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id516cb2907a6a02570ef0f538d5593c378a8802d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
