jenkins-bot has submitted this change and it was merged.
Change subject: apache debug log permission need to be done by Job
......................................................................
apache debug log permission need to be done by Job
I attempted to fix the Apache debug log permission but forgot the code
path was being run by Apache. It does not have the permission to fix
the permission, that needs to be done by jenkins-slave user.
Will update the JJB qunit macro so it creates the file for us and apply
a world writable permission.
Change-Id: I005e783b54a24226aa6fd0158f67c6675f0afa13
---
M mediawiki/conf.d/00_set_debug_log.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/mediawiki/conf.d/00_set_debug_log.php
b/mediawiki/conf.d/00_set_debug_log.php
index 51e97e8..7740d3f 100644
--- a/mediawiki/conf.d/00_set_debug_log.php
+++ b/mediawiki/conf.d/00_set_debug_log.php
@@ -10,7 +10,7 @@
# Under Apache, there is no Jenkins environnement variable. Since
MediaWiki
# include path is the workspace, use $IP instead.
$wgDebugLogFile = $IP . '/log/mw-debug-www.log';
- # Make sure it is writable by Apache:
- touch( $wgDebugLogFile );
- chmod( $wgDebugLogFile, '0666' );
+ # The resulting file has to be created by a shell script in Jenkins
+ # See qunit builder macro which takes care of creation and permission
+ # fixing (aka world writable)
}
--
To view, visit https://gerrit.wikimedia.org/r/90355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I005e783b54a24226aa6fd0158f67c6675f0afa13
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
