Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/90361


Change subject: Fixed up undefined variable noise
......................................................................

Fixed up undefined variable noise

reedy@tin:/a/common$ ./multiversion/deleteMediaWiki php-1.22wmf10

Deleting symlink files for MediaWiki install at /a/common/php-1.22wmf10...

Symlink file removed: /a/common/docroot/bits/static-1.22wmf10/skins
Symlink file removed: /a/common/docroot/bits/static-1.22wmf10/extensions
Symlink file removed: /a/common/docroot/bits/static-1.22wmf10/resources
Symlink file removed: /a/common/w/static-1.22wmf10/skins
Symlink file removed: /a/common/w/static-1.22wmf10/extensions
Symlink file removed: /a/common/w/static-1.22wmf10/resources
Directory removed: /a/common/docroot/bits/static-1.22wmf10
Directory removed: /a/common/w/static-1.22wmf10

References to MediaWiki 1.22wmf10 deleted.
PHP Warning:  Missing argument 1 for updateBitsBranchPointers(), called in 
/a/common/multiversion/deleteMediaWiki on line 95 and defined in 
/a/common/multiversion/updateBitsBranchPointers on line 22
Updating current branch pointer...
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 40
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 71
/a/common/docroot/bits/static-current/skins => 
/usr/local/apache/common-local/php-1.22wmf21/skins
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 71
/a/common/docroot/bits/static-current/extensions => 
/usr/local/apache/common-local/php-1.22wmf21/extensions
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 71
/a/common/docroot/bits/static-current/resources => 
/usr/local/apache/common-local/php-1.22wmf21/resources

Updating stable branch pointer...
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 40
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 71
/a/common/docroot/bits/static-stable/skins => 
/usr/local/apache/common-local/php-1.22wmf20/skins
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 71
/a/common/docroot/bits/static-stable/extensions => 
/usr/local/apache/common-local/php-1.22wmf20/extensions
PHP Notice:  Undefined variable: dryRun in 
/a/common/multiversion/updateBitsBranchPointers on line 71
/a/common/docroot/bits/static-stable/resources => 
/usr/local/apache/common-local/php-1.22wmf20/resources

reedy@tin:/a/common$

Change-Id: Id30b59abe37705cf3931066f5ee43a3159ff73e7
---
M multiversion/updateBitsBranchPointers
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/61/90361/1

diff --git a/multiversion/updateBitsBranchPointers 
b/multiversion/updateBitsBranchPointers
index 2385243..0cfbb7d 100755
--- a/multiversion/updateBitsBranchPointers
+++ b/multiversion/updateBitsBranchPointers
@@ -19,7 +19,7 @@
        return basename( __FILE__ ) === basename( $_SERVER['SCRIPT_FILENAME'] );
 }
 
-function updateBitsBranchPointers( $dryRun ) {
+function updateBitsBranchPointers( $dryRun = false ) {
        $branchDirs = glob( MULTIVER_COMMON_APACHE . '/php-*', GLOB_ONLYDIR );
 
        if ( !is_array( $branchDirs ) || count( $branchDirs ) < 1 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/90361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id30b59abe37705cf3931066f5ee43a3159ff73e7
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to