jenkins-bot has submitted this change and it was merged.
Change subject: Update browsertests for string change
......................................................................
Update browsertests for string change
Creating topic was looking for "about 1 second" or "just now", but the
former string changed to "1 second ago".
With this tests pass on beta labs and ee-proto.
Change-Id: Iea01a08e2477a001dfadb76b485853e4d218222b
---
M tests/browser/features/step_definitions/flow_steps.rb
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/flow_steps.rb
b/tests/browser/features/step_definitions/flow_steps.rb
index f9b8545..9a8b186 100644
--- a/tests/browser/features/step_definitions/flow_steps.rb
+++ b/tests/browser/features/step_definitions/flow_steps.rb
@@ -25,7 +25,15 @@
Then(/^the Flow page should contain (.+)$/) do |flow_topic|
on(FlowPage) do |page|
page.wait_until(20) do # 10 seconds wasn't enough on ee-flow...
- page.text.include? 'about 1 second' or page.text.include? 'just now'
+ # TODO Also match the regexp '[2-9] seconds ago' in case of delays.
+ # TODO This should look in the particular topic that was added, not
+ # blindly look for text.
+ # It could note the ID of the first div with id 'flow-topic-<UUID>'
+ # before submitting the new topic post,
+ # then afterwards find the flow-topic-<UUID> div *preceding* that and
search in there.
+ # Or after submit it could look for the Title of Flow Topic, find the
+ # flow-topic-container containing that and search in there.
+ page.text.include? '1 second ago' or page.text.include? 'just now'
end
page.flow_body.should match(flow_topic + @random_string +
@automated_test_marker)
end
--
To view, visit https://gerrit.wikimedia.org/r/89389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea01a08e2477a001dfadb76b485853e4d218222b
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
