Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/90691


Change subject: Remove the zoom system from Page: pages view
......................................................................

Remove the zoom system from Page: pages view

It was unusable because of the lack of buttons

Change-Id: I83de93833abb626f8337455affdf239ed95ce44a
---
M modules/page/ext.proofreadpage.page.css
M modules/page/ext.proofreadpage.page.edit.js
M modules/page/ext.proofreadpage.page.js
3 files changed, 21 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/91/90691/1

diff --git a/modules/page/ext.proofreadpage.page.css 
b/modules/page/ext.proofreadpage.page.css
index d8decea..8a7c86d 100644
--- a/modules/page/ext.proofreadpage.page.css
+++ b/modules/page/ext.proofreadpage.page.css
@@ -13,6 +13,11 @@
        overflow: auto;
 }
 
+.prp-page-image img {
+       width: 100%;
+       height: auto;
+}
+
 #prp-page-qualityheader {
        width: 100%;
 }
diff --git a/modules/page/ext.proofreadpage.page.edit.js 
b/modules/page/ext.proofreadpage.page.edit.js
index 03a163e..db4d1d6 100644
--- a/modules/page/ext.proofreadpage.page.edit.js
+++ b/modules/page/ext.proofreadpage.page.edit.js
@@ -185,9 +185,25 @@
                }
        }
 
+       /**
+        * Init the zoom system
+        */
+       function initZoom() {
+               var $image = $( '.prp-page-image img' );
+               if( $image.length === 0 ) {
+                       return;
+               }
+               mw.loader.using( 'jquery.panZoom', function() {
+                       $image.panZoom();
+                       $image.panZoom( 'loadImage' );
+                       $image.panZoom( 'fitWidth' );
+               } );
+       }
+
        $( document ).ready( function() {
                setupPreferences();
                setupPageQuality();
+               initZoom();
                addButtons();
        } );
 
diff --git a/modules/page/ext.proofreadpage.page.js 
b/modules/page/ext.proofreadpage.page.js
index b6f5cf9..73741cd 100644
--- a/modules/page/ext.proofreadpage.page.js
+++ b/modules/page/ext.proofreadpage.page.js
@@ -2,21 +2,6 @@
        'use strict';
 
        /**
-        * Init the zoom system
-        */
-       function initZoom() {
-               var $image = $( '.prp-page-image img' );
-               if( $image.length === 0 ) {
-                       return;
-               }
-               mw.loader.using( 'jquery.panZoom', function() {
-                       $image.panZoom();
-                       $image.panZoom( 'loadImage' );
-                       $image.panZoom( 'fitWidth' );
-               } );
-       }
-
-       /**
         * Get the selector for the main tabs container
         *
         * @return string
@@ -52,7 +37,6 @@
 
        $( document ).ready( function() {
                initTabs();
-               initZoom();
        } );
 
 } ( mediaWiki, jQuery ) );
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/90691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83de93833abb626f8337455affdf239ed95ce44a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: pagePagesRefactoring
Gerrit-Owner: Tpt <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to