jenkins-bot has submitted this change and it was merged.

Change subject: Use hard newlines instead of groups
......................................................................


Use hard newlines instead of groups

Export is being done in different threads in the same shell. This could
cause multiple output to be put on the same line, making it less readable.

Change-Id: I65ca7cd9fa26cc23fc4a10c3a6096397ab37f495
---
M scripts/export.php
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/export.php b/scripts/export.php
index 2250ab0..6a3e48d 100644
--- a/scripts/export.php
+++ b/scripts/export.php
@@ -140,12 +140,12 @@
 
                        if ( $group->isMeta() ) {
                                if ( !$coreMeta ) {
-                                       $this->output( "Skipping meta message 
group $groupId.", $groupId );
+                                       $this->output( "Skipping meta message 
group $groupId.\n" );
                                        unset( $groups[$groupId] );
                                        continue;
                                } elseif ( strstr( $group->getId(), 'core-1', 
true ) !== '' ) {
                                        // Special case for MediaWiki core 
branches.
-                                       $this->output( "Skipping meta message 
group $groupId.", $groupId );
+                                       $this->output( "Skipping meta message 
group $groupId.\n" );
                                        unset( $groups[$groupId] );
                                        continue;
                                }
@@ -191,13 +191,13 @@
 
                foreach ( $groups as $groupId => $group ) {
                        if ( in_array( $groupId, $skipGroups ) ) {
-                               $this->output( "Group $groupId is in 
skipgroup.", $groupId );
+                               $this->output( "Group $groupId is in 
skipgroup.\n" );
                                continue;
                        }
 
                        // No changes to this group at all
                        if ( is_array( $changeFilter ) && !isset( 
$changeFilter[$groupId] ) ) {
-                               $this->output( "No recent changes to 
$groupId.", $groupId );
+                               $this->output( "No recent changes to 
$groupId.\n" );
                                continue;
                        }
 
@@ -235,7 +235,7 @@
                                continue;
                        }
 
-                       $this->output( "Exporting $groupId...", $groupId );
+                       $this->output( "Exporting $groupId...\n" );
 
                        if ( $group instanceof FileBasedMessageGroup ) {
                                $ffs = $group->getFFS();

-- 
To view, visit https://gerrit.wikimedia.org/r/90023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65ca7cd9fa26cc23fc4a10c3a6096397ab37f495
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to