Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/90858


Change subject: installer: Make css error more discoverable
......................................................................

installer: Make css error more discoverable

Like we do in load.php, prepend them instead of burying in the
middle somewhere.

Change-Id: I69b0ce7f40e86bf31cb84f4d69222e62b25aa002
---
M includes/installer/WebInstallerOutput.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/90858/1

diff --git a/includes/installer/WebInstallerOutput.php 
b/includes/installer/WebInstallerOutput.php
index 1df8f05..d4300de 100644
--- a/includes/installer/WebInstallerOutput.php
+++ b/includes/installer/WebInstallerOutput.php
@@ -128,6 +128,7 @@
                        'common/config.css',
                );
 
+               $prepend = '';
                $css = '';
 
                wfSuppressWarnings();
@@ -139,13 +140,16 @@
                                $skinName = $match[1];
                                $css .= str_replace( 'images/', 
"../skins/$skinName/images/", $cssFileContents );
                        } else {
-                               $css .= "/** Your webserver cannot read 
$fullCssFileName. Please check file permissions. */";
+                               $prepend .= "/** Unable to read 
$fullCssFileName. Please check file permissions. */\n";
                        }
 
                        $css .= "\n";
                }
                wfRestoreWarnings();
 
+
+               $css = $prepend . $css;
+
                if ( $dir == 'rtl' ) {
                        $css = CSSJanus::transform( $css, true );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/90858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69b0ce7f40e86bf31cb84f4d69222e62b25aa002
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to