Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/91290
Change subject: Recalculate $resizable offset when positioning resize label
......................................................................
Recalculate $resizable offset when positioning resize label
Because it can change. Currently the resize label is not
position correctly if you use three of four resize handles.
Change-Id: I1a28bc57fda1097c94047fd7690ad8d403cdd478
---
M modules/ve/ce/ve.ce.ResizableNode.js
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/90/91290/1
diff --git a/modules/ve/ce/ve.ce.ResizableNode.js
b/modules/ve/ce/ve.ce.ResizableNode.js
index 4878a2c..f9a58b5 100644
--- a/modules/ve/ce/ve.ce.ResizableNode.js
+++ b/modules/ve/ce/ve.ce.ResizableNode.js
@@ -82,21 +82,24 @@
if ( !this.$sizeLabel ) {
return;
}
- var node, top, height;
+ var offset, node, top, height;
if ( dimensions ) {
+ offset = ve.Element.getRelativePosition(
+ this.$resizable,
this.getRoot().getSurface().getSurface().$
+ );
// Things get a bit tight below 100px, so put the label on the
outside
if ( dimensions.width < 100 ) {
- top = dimensions.top + dimensions.height;
+ top = offset.top + dimensions.height;
height = 30;
} else {
- top = dimensions.top;
+ top = offset.top;
height = dimensions.height;
}
this.$sizeLabel
.addClass( 've-ce-resizableNode-sizeLabel-resizing' )
.css( {
'top': top,
- 'left': dimensions.left,
+ 'left': offset.left,
'width': dimensions.width,
'height': height,
'lineHeight': height + 'px'
--
To view, visit https://gerrit.wikimedia.org/r/91290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a28bc57fda1097c94047fd7690ad8d403cdd478
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
