jenkins-bot has submitted this change and it was merged.
Change subject: mw.inspect: decline to report module sizes when in debug mode
......................................................................
mw.inspect: decline to report module sizes when in debug mode
- In debug mode, 1 resource = 1 request, so module size is easier to determine
via the network view of the developer tools in Firefox & WebKit browsers.
- Determining the module size in debug mode in JavaScript would require
modifying core ResourceLoader code or re-fetching each resource with a
separate XHR to measure its size.
- It's not worth it.
Bug: 55553
Change-Id: I73d1bb4141c1b6ed64a72fdc416048937a2e1146
(cherry picked from commit 251e4d4acf4704a8bd58492835870087e56ebbee)
---
M resources/mediawiki/mediawiki.inspect.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.inspect.js
b/resources/mediawiki/mediawiki.inspect.js
index c4766ff..5cecc16 100644
--- a/resources/mediawiki/mediawiki.inspect.js
+++ b/resources/mediawiki/mediawiki.inspect.js
@@ -97,6 +97,11 @@
}
};
+ if ( mw.config.get( 'debug' ) ) {
+ inspect.getModuleSize = function () { return null; };
+ mw.log( 'mw.inspect: Module sizes are not available in debug
mode.' );
+ }
+
mw.inspect = inspect;
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/91299
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73d1bb4141c1b6ed64a72fdc416048937a2e1146
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.22wmf21
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
