Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/91356
Change subject: Stash: fix one tests, mark one as pending
......................................................................
Stash: fix one tests, mark one as pending
Change-Id: I5e43e8c068263b399b57ef244c86c0ef26052947
---
M tests/browser/features/step_definitions/translation_stash_steps.rb
M tests/browser/features/support/pages/stash_page.rb
M tests/browser/features/translation_stash.feature
3 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/56/91356/1
diff --git a/tests/browser/features/step_definitions/translation_stash_steps.rb
b/tests/browser/features/step_definitions/translation_stash_steps.rb
index 8027525..c788533 100644
--- a/tests/browser/features/step_definitions/translation_stash_steps.rb
+++ b/tests/browser/features/step_definitions/translation_stash_steps.rb
@@ -33,8 +33,11 @@
visit(StashPage)
end
-Then(/^I can see and edit my earlier translation$/) do
- on(StashPage).translation_element.when_present.value.should == 'Pupu'
+Then(/^I can open and see my earlier translation$/) do
+ on(StashPage) do |page|
+ page.edit_element.when_present(10).click
+ page.translation_element.when_present.value.should == 'Pupu'
+ end
end
Then(/^I should see a message indicating I have one completed translation$/) do
@@ -42,6 +45,8 @@
end
When(/^I translate all the messages in the sandbox$/) do
+ # Sandbox needs to get enough messages
+ pending
(0..19).each do |i|
on(StashPage).make_a_translation(i)
step 'I should see my translation saved'
diff --git a/tests/browser/features/support/pages/stash_page.rb
b/tests/browser/features/support/pages/stash_page.rb
index 15c8cae..4a9bc6b 100644
--- a/tests/browser/features/support/pages/stash_page.rb
+++ b/tests/browser/features/support/pages/stash_page.rb
@@ -4,6 +4,8 @@
include URL
page_url URL.url('Special:TranslationStash?<%=params[:extra]%>')
+ a(:edit, text: 'Edit')
+
span(:language_selector, :class => 'uls')
text_field(:language_filter, :id => 'languagefilter')
diff --git a/tests/browser/features/translation_stash.feature
b/tests/browser/features/translation_stash.feature
index 83e2e9b..9b1acd6 100644
--- a/tests/browser/features/translation_stash.feature
+++ b/tests/browser/features/translation_stash.feature
@@ -37,7 +37,7 @@
When I make a translation
Then I should see my translation saved
And I reload the page
- And I can see and edit my earlier translation
+ And I can open and see my earlier translation
Scenario: User is displayed a message when all messages have been translated
When I translate all the messages in the sandbox
--
To view, visit https://gerrit.wikimedia.org/r/91356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e43e8c068263b399b57ef244c86c0ef26052947
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
