Raimond Spekking has uploaded a new change for review.
https://gerrit.wikimedia.org/r/91379
Change subject: Avoid empty values for JS variables
wgMonthNames/wgMonthNamesShort
......................................................................
Avoid empty values for JS variables wgMonthNames/wgMonthNamesShort
The output currently is:
"wgMonthNames": [
"",
"Januar",
"Februar",
"März",
"April",
"Mai",
"Juni",
"Juli",
"August",
"September",
"Oktober",
"November",
"Dezember"
],
I don't see a need for an empty value
Change-Id: I2b327c20f6aa07a31d681ea349365a86480526c0
---
M languages/Language.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/79/91379/1
diff --git a/languages/Language.php b/languages/Language.php
index 527f382..59868b3 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -965,7 +965,7 @@
* @return array
*/
function getMonthNamesArray() {
- $monthNames = array( '' );
+ $monthNames = array();
for ( $i = 1; $i < 13; $i++ ) {
$monthNames[] = $this->getMonthName( $i );
}
@@ -992,7 +992,7 @@
* @return array
*/
function getMonthAbbreviationsArray() {
- $monthNames = array( '' );
+ $monthNames = array();
for ( $i = 1; $i < 13; $i++ ) {
$monthNames[] = $this->getMonthAbbreviation( $i );
}
--
To view, visit https://gerrit.wikimedia.org/r/91379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b327c20f6aa07a31d681ea349365a86480526c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits