PleaseStand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/91563
Change subject: mw.language.convertPlural: Check if matching form exists
......................................................................
mw.language.convertPlural: Check if matching form exists
Same reason as for d510d0c0c7dd: return the empty string instead
of undefined when no matching form exists, as intended.
Change-Id: I52df4c88d822cdf5f318651a08f1f120ea924e9c
---
M resources/mediawiki.language/mediawiki.language.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/91563/1
diff --git a/resources/mediawiki.language/mediawiki.language.js
b/resources/mediawiki.language/mediawiki.language.js
index 631d13d..df8ba64 100644
--- a/resources/mediawiki.language/mediawiki.language.js
+++ b/resources/mediawiki.language/mediawiki.language.js
@@ -51,10 +51,6 @@
equalsPosition,
pluralFormIndex = 0;
- if ( !forms || forms.length === 0 ) {
- return '';
- }
-
// Handle for explicit n= forms
for ( index = 0; index < forms.length; index++ ) {
form = forms[index];
@@ -73,6 +69,10 @@
return form;
} );
+ if ( forms.length === 0 ) {
+ return '';
+ }
+
pluralRules = mw.language.getData( mw.config.get(
'wgUserLanguage' ), 'pluralRules' );
if ( !pluralRules ) {
// default fallback.
--
To view, visit https://gerrit.wikimedia.org/r/91563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52df4c88d822cdf5f318651a08f1f120ea924e9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
