jenkins-bot has submitted this change and it was merged.
Change subject: Only add handlers on image thumbnails
......................................................................
Only add handlers on image thumbnails
None of this PDF handler business.
Whitelist may be a little incomplete, but I think it comprises most of
the images on Commons at least. We can revisit later.
Change-Id: I33a44f8de8b0e93818f7cc950d8cae11bd73b929
---
M js/ext.multimediaViewer.js
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/ext.multimediaViewer.js b/js/ext.multimediaViewer.js
index 197920b..7ef567f 100644
--- a/js/ext.multimediaViewer.js
+++ b/js/ext.multimediaViewer.js
@@ -17,6 +17,16 @@
( function ( mw, $ ) {
var MultiLightbox, LightboxImage, lightboxHooks,
+ validExtensions = {
+ 'jpg': true,
+ 'jpeg': true,
+ 'gif': true,
+ 'svg': true,
+ 'png': true,
+ 'tiff': true,
+ 'tif': true
+ },
+
iiprops = [
'timestamp',
'user',
@@ -49,6 +59,11 @@
fileTitle = mw.Title.newFromImg( $thumb ),
index = urls.length;
+ if (
!validExtensions[fileTitle.getExtension().toLowerCase()] ) {
+ // Not a valid extension, skip this one
+ return;
+ }
+
$links.data( 'filePageLink', filePageLink );
urls.push( new LightboxImage( fileLink ) );
urls[index].filePageLink = filePageLink;
--
To view, visit https://gerrit.wikimedia.org/r/90455
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33a44f8de8b0e93818f7cc950d8cae11bd73b929
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
