Hello Milimetric,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/91678
to review the following change.
Change subject: Use function's basedir instead of script invocation's
......................................................................
Use function's basedir instead of script invocation's
Card: analytics 1168
Change-Id: I8a9f29abde079a12fd8e06ff69ba81b37c62ee04
---
M scripts/make_limn_files.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/geowiki
refs/changes/78/91678/1
diff --git a/scripts/make_limn_files.py b/scripts/make_limn_files.py
index 3320270..9055bda 100755
--- a/scripts/make_limn_files.py
+++ b/scripts/make_limn_files.py
@@ -331,18 +331,18 @@
# db = sql.connect('/home/erosen/src/editor-geocoding/geowiki.sqlite')
- write_project_mysql(project, cursor, args.basedir)
- write_project_top_k_mysql(project, cursor, args.basedir, k=args.k)
- #write_project_country_language(project, cursor, args.basedir)
+ write_project_mysql(project, cursor, basedir)
+ write_project_top_k_mysql(project, cursor, basedir, k=args.k)
+ #write_project_country_language(project, cursor, basedir)
except:
logger.exception('caught exception in process:')
raise
def process_project(project, cursor, basedir):
logger.info('processing project: %s (%d/%d)', project, i, len(projects))
- write_project_mysql(project, cursor, args.basedir)
- write_project_top_k_mysql(project, cursor, args.basedir, k=args.k)
- #write_project_country_language(project, cursor, args.basedir)
+ write_project_mysql(project, cursor, basedir)
+ write_project_top_k_mysql(project, cursor, basedir, k=args.k)
+ #write_project_country_language(project, cursor, basedir)
def plot_gs_editor_fraction(basedir):
df = pd.read_csv(basedir + '/datafiles/global_south.csv',
index_col='date', parse_dates=['date'])
--
To view, visit https://gerrit.wikimedia.org/r/91678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a9f29abde079a12fd8e06ff69ba81b37c62ee04
Gerrit-PatchSet: 1
Gerrit-Project: analytics/geowiki
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
