jenkins-bot has submitted this change and it was merged.

Change subject: mediawiki.inspect: Support IE8's style.sheet.rules property
......................................................................


mediawiki.inspect: Support IE8's style.sheet.rules property

Standards-compliant browsers use 'cssRules', IE8 uses 'rules',
some browsers (e.g. Chrome) support both.

Bug: 56107
Change-Id: Ief0b5e38c8ff29efea510bf3725127c2bbfccd59
(cherry picked from commit 6fad6f5d24ecce46317fe65b53e7c4c7f9c63ef5)
---
M resources/mediawiki/mediawiki.inspect.js
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mediawiki/mediawiki.inspect.js 
b/resources/mediawiki/mediawiki.inspect.js
index c895adf..346e783 100644
--- a/resources/mediawiki/mediawiki.inspect.js
+++ b/resources/mediawiki/mediawiki.inspect.js
@@ -65,11 +65,15 @@
                 */
                auditSelectors: function ( css ) {
                        var selectors = { total: 0, matched: 0 },
-                               style = document.createElement( 'style' );
+                               style = document.createElement( 'style' ),
+                               sheet, rules;
 
                        style.textContent = css;
                        document.body.appendChild( style );
-                       $.each( style.sheet.cssRules, function ( index, rule ) {
+                       // Standards-compliant browsers use .sheet.cssRules, 
IE8 uses .styleSheet.rules…
+                       sheet = style.sheet || style.styleSheet;
+                       rules = sheet.cssRules || sheet.rules;
+                       $.each( rules, function ( index, rule ) {
                                selectors.total++;
                                if ( document.querySelector( rule.selectorText 
) !== null ) {
                                        selectors.matched++;

-- 
To view, visit https://gerrit.wikimedia.org/r/91766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief0b5e38c8ff29efea510bf3725127c2bbfccd59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_22
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to