jenkins-bot has submitted this change and it was merged.
Change subject: Fix crash in parserTests
......................................................................
Fix crash in parserTests
|| has higher precedence than &&
Introduced in f27904aef1b096211fd665e6106baec1ff6afb6c.
Change-Id: I8221edf61206fe9ca79b10a99c07e15d9676e7d3
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.WikitextSerializer.js
b/js/lib/mediawiki.WikitextSerializer.js
index c8838a2..4edd88f 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -1786,14 +1786,14 @@
linkData.type = 'mw:WikiLink';
linkData.isInterwiki = true;
var oldPrefix =
target.value.match(/^(:?[^:]+):/);
- if (oldPrefix &&
+ if (oldPrefix && (
oldPrefix[1].toLowerCase() ===
interWikiMatch[0].toLowerCase() ||
// Check if the old prefix
mapped to the same URL as
// the new one. Use the old one
if that's the case.
// Example: [[w:Foo]] vs.
[[:en:Foo]]
(env.conf.wiki.interwikiMap[oldPrefix[1].toLowerCase()] || {}).url ===
(env.conf.wiki.interwikiMap[interWikiMatch[0].replace(/^:/, '')] || {}).url
- )
+ ))
{
// Reuse old prefix capitalization
if
(Util.decodeEntities(target.value.substr(oldPrefix[1].length+1)) !==
interWikiMatch[1])
--
To view, visit https://gerrit.wikimedia.org/r/91769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8221edf61206fe9ca79b10a99c07e15d9676e7d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
