Brion VIBBER has submitted this change and it was merged.

Change subject: Don't fail mvn checkstyle:checkstyle when checkstyle fails
......................................................................


Don't fail mvn checkstyle:checkstyle when checkstyle fails

Just because checkstyle fails doesn't mean it shouldn't generate
output

Change-Id: If079edea5ca4f6477d6fc5e87a5eea503cdd1230
---
M pom.xml
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/pom.xml b/pom.xml
index fbc0a23..02c8467 100644
--- a/pom.xml
+++ b/pom.xml
@@ -36,7 +36,6 @@
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <version>2.10</version>
                 <configuration>
-                    <failsOnError>true</failsOnError>
                     <configLocation>checkstyle.xml</configLocation>
                     <consoleOutput>true</consoleOutput>
                     <linkXRef>false</linkXRef>

-- 
To view, visit https://gerrit.wikimedia.org/r/91771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If079edea5ca4f6477d6fc5e87a5eea503cdd1230
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/java-mwapi
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to