Adamw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/91823
Change subject: improve historical campaign lookup
......................................................................
improve historical campaign lookup
Move the "enabled" check to the db query
Change-Id: I9e3d38fcad39ee02eb4f264068328e16989471ae
---
M includes/Campaign.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/23/91823/1
diff --git a/includes/Campaign.php b/includes/Campaign.php
index e7cc85e..ea585f2 100644
--- a/includes/Campaign.php
+++ b/includes/Campaign.php
@@ -483,12 +483,13 @@
"notlog_id = {$row->log_id}",
"notlog_end_start <= $ts",
"notlog_end_end >= $ts",
+ "notlog_end_enabled = 1",
),
__METHOD__
);
$campaign = $singleRes->fetchRow();
- if ( !$campaign or $campaign['enabled'] !== "1" ) {
+ if ( !$campaign ) {
continue;
}
$campaign['projects'] = explode( ", ",
$campaign['projects'] );
--
To view, visit https://gerrit.wikimedia.org/r/91823
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e3d38fcad39ee02eb4f264068328e16989471ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
