Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/91851


Change subject: Make test more robust
......................................................................

Make test more robust

The same element is used for percentages. If those get loaded
before this check, the test fails.

Change-Id: I2530b9aac2a21d020e337a0132e510a6c0c79ea9
---
M tests/browser/features/step_definitions/signed_in_source_language_steps.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage 
refs/changes/51/91851/1

diff --git 
a/tests/browser/features/step_definitions/signed_in_source_language_steps.rb 
b/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
index 3527b72..409ee98 100644
--- a/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
+++ b/tests/browser/features/step_definitions/signed_in_source_language_steps.rb
@@ -34,7 +34,7 @@
 end
 
 Then(/^I should not see the number of messages in the project tiles$/) do
-       on(MainPage).statstext_element.text.should == ''
+       on(MainPage).statstext_element.text.should_not match(/\d+ messages/)
 end
 
 When(/^I should see statsbars in the project tiles$/) do

-- 
To view, visit https://gerrit.wikimedia.org/r/91851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2530b9aac2a21d020e337a0132e510a6c0c79ea9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to