Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/91874


Change subject: Improve date display
......................................................................

Improve date display

Strip any non-text content from the creation/upload date string,
and, if possible,  parse and format (according to browser locale)
the result.

Bug: 56146
Change-Id: I214e53c5219335b7a9fc852dc029b2992ca56435
---
M js/ext.multimediaViewer.js
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/74/91874/1

diff --git a/js/ext.multimediaViewer.js b/js/ext.multimediaViewer.js
old mode 100644
new mode 100755
index 168561b..c1865ff
--- a/js/ext.multimediaViewer.js
+++ b/js/ext.multimediaViewer.js
@@ -227,11 +227,17 @@
                                                datetime = 
extmeta.DateTimeOriginal || extmeta.DateTime;
 
                                                if ( datetime ) {
+                            // get rid of HTML tags
+                            datetime = $( $.parseHTML( datetime.value ) 
).text()
+                            // try to use built in date formatting
+                            if ( new Date(datetime) ) {
+                                datetime = ( new Date(datetime) 
).toLocaleDateString();
+                            }
+
                                                        dtmsg = (
                                                                
'multimediaviewer-datetime-' +
                                                                ( 
extmeta.DateTimeOriginal ? 'created' : 'uploaded' )
                                                        );
-                                                       datetime = 
datetime.value;
 
                                                        ui.$datetime.text(
                                                                mw.message( 
dtmsg, datetime ).text()

-- 
To view, visit https://gerrit.wikimedia.org/r/91874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I214e53c5219335b7a9fc852dc029b2992ca56435
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: GergÅ‘ Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to