Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/91988
Change subject: Hygiene: Consolidate ajax loading code
......................................................................
Hygiene: Consolidate ajax loading code
Change-Id: I9c645104b2bb15867300eb6c623b4add2ea354cf
---
M less/common/common-js.less
M less/common/navigation.less
M less/modules/mediaViewer.less
M less/modules/talk.less
M less/modules/uploads.less
5 files changed, 6 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/88/91988/1
diff --git a/less/common/common-js.less b/less/common/common-js.less
index 8cb93f3..32de6ac 100644
--- a/less/common/common-js.less
+++ b/less/common/common-js.less
@@ -1,12 +1,17 @@
@import "../mixins.less";
.loading {
+ img,
+ a {
+ display: none;
+ }
+
&.spinner {
height: 100px;
}
// needs !important to override images from more specific rules
- background-image: url(images/ajax-loader.gif) !important;
+ background-image: @ajaxLoadingImage !important;
background-repeat: no-repeat;
background-position: center;
.background-size( 32px, auto );
diff --git a/less/common/navigation.less b/less/common/navigation.less
index 1e8a010..e0ba1c9 100644
--- a/less/common/navigation.less
+++ b/less/common/navigation.less
@@ -10,10 +10,6 @@
&.watched {
background-image: url(../common/images/watched.png);
}
-
- &.loading {
- background-image: @ajaxLoadingImage;
- }
}
.search.error,
diff --git a/less/modules/mediaViewer.less b/less/modules/mediaViewer.less
index 1881b5e..4aa33c5 100644
--- a/less/modules/mediaViewer.less
+++ b/less/modules/mediaViewer.less
@@ -18,10 +18,6 @@
}
}
- .loading img {
- display: none;
- }
-
img {
// get rid of a small bottom margin and vertical scrollbar
vertical-align: bottom;
diff --git a/less/modules/talk.less b/less/modules/talk.less
index bb658e6..d85642e 100644
--- a/less/modules/talk.less
+++ b/less/modules/talk.less
@@ -10,10 +10,6 @@
padding-left: 4px;
font-size: 9px; // FIXME: use pixels for time being as the icon
in pixels.
}
-
- &.loading a {
- display: none;
- }
}
.mw-mf-overlay .header {
diff --git a/less/modules/uploads.less b/less/modules/uploads.less
index 79b77d3..2998973 100644
--- a/less/modules/uploads.less
+++ b/less/modules/uploads.less
@@ -89,10 +89,6 @@
height: 50%;
.background-size( 100%, auto );
background-repeat: no-repeat;
-
- &.loading {
- .background-size( 32px, auto );
- }
}
li {
--
To view, visit https://gerrit.wikimedia.org/r/91988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c645104b2bb15867300eb6c623b4add2ea354cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
