Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/91994
Change subject: wait for errorbox, this causes flaky IE failures ...................................................................... wait for errorbox, this causes flaky IE failures Change-Id: I0fe09bda532cab6c36d52b4cb2298d116f3aaf36 --- M features/step_definitions/login_steps.rb 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/94/91994/1 diff --git a/features/step_definitions/login_steps.rb b/features/step_definitions/login_steps.rb index 1c6e0d9..91e5e63 100644 --- a/features/step_definitions/login_steps.rb +++ b/features/step_definitions/login_steps.rb @@ -30,8 +30,11 @@ end Then(/^feedback should be (.+)$/) do |feedback| - on(LoginPage).feedback.should match Regexp.escape(feedback) -end + on(LoginPage) do |page| + page.feedback_element.when_present.click + page.feedback.should match Regexp.escape(feedback) + end + end Then(/^Log in element should be there$/) do on(LoginPage).login_element.should exist end -- To view, visit https://gerrit.wikimedia.org/r/91994 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0fe09bda532cab6c36d52b4cb2298d116f3aaf36 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
