Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92019
Change subject: WIP: QA Add basic nearby tests for Vector
......................................................................
WIP: QA Add basic nearby tests for Vector
Change-Id: Ie205e5b3729610792bc47b0c7ac74b8ddb1b19f1
---
A tests/browser/features/nearby_desktop.feature
M tests/browser/features/step_definitions/nearby_steps.rb
M tests/browser/features/support/modules/url_module.rb
A tests/browser/features/support/pages/nearby_vector_page.rb
4 files changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/19/92019/1
diff --git a/tests/browser/features/nearby_desktop.feature
b/tests/browser/features/nearby_desktop.feature
new file mode 100644
index 0000000..0486642
--- /dev/null
+++ b/tests/browser/features/nearby_desktop.feature
@@ -0,0 +1,6 @@
+Feature: Nearby
+ Background:
+ Given I am on the nearby page on Vector
+
+ Scenario: Nearby shows results
+ Then I see a result in the page list
diff --git a/tests/browser/features/step_definitions/nearby_steps.rb
b/tests/browser/features/step_definitions/nearby_steps.rb
index 42ea325..965c251 100644
--- a/tests/browser/features/step_definitions/nearby_steps.rb
+++ b/tests/browser/features/step_definitions/nearby_steps.rb
@@ -2,6 +2,10 @@
visit(NearbyPage)
end
+Given(/^I am on the nearby page on Vector$/) do
+ visit(NearbyVectorPage)
+end
+
Then(/^I see a result in the page list$/) do
on(NearbyPage).results_element.when_present.should exist
end
diff --git a/tests/browser/features/support/modules/url_module.rb
b/tests/browser/features/support/modules/url_module.rb
index 1fd7298..2be73c3 100644
--- a/tests/browser/features/support/modules/url_module.rb
+++ b/tests/browser/features/support/modules/url_module.rb
@@ -1,10 +1,10 @@
module URL
- def self.url(name)
+ def self.url(name, qs="?useformat=mobile")
if ENV['MEDIAWIKI_URL']
mediawiki_url = ENV['MEDIAWIKI_URL']
else
mediawiki_url = 'http://127.0.0.1:80/w/index.php'
end
- "#{mediawiki_url}#{name}?useformat=mobile"
+ "#{mediawiki_url}#{name}#{qs}"
end
end
diff --git a/tests/browser/features/support/pages/nearby_vector_page.rb
b/tests/browser/features/support/pages/nearby_vector_page.rb
new file mode 100644
index 0000000..69e857e
--- /dev/null
+++ b/tests/browser/features/support/pages/nearby_vector_page.rb
@@ -0,0 +1,7 @@
+class NearbyVectorPage
+ include PageObject
+ include URL
+ page_url URL.url('Special:Nearby', '?useformat=desktop&useskin=vector')
+ div(:bodyContent, id: 'bodyContent')
+ ul(:results, class: 'page-list a-to-z actionable')
+end
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/92019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie205e5b3729610792bc47b0c7ac74b8ddb1b19f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
