MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92034
Change subject: Fix EL dependency loading
......................................................................
Fix EL dependency loading
Do it in an extension function. Cool feature.
Change-Id: I4a11d13d8c0742106ce4dda15b6b3caaa6489421
---
M MultimediaViewer.php
1 file changed, 14 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/34/92034/1
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index ab0996b..a27def6 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -79,17 +79,23 @@
),
), $moduleInfo );
-if ( isset( $wgResourceModules['ext.eventLogging'] ) ) {
- $wgResourceModules['schema.MediaViewer'] = array(
- 'class' => 'ResourceLoaderSchemaModule',
- 'schema' => 'MediaViewer',
- 'revision' => 6055641,
- );
+function addElDependencies() {
+ global $wgResourceModules;
- $wgResourceModules['ext.multimediaViewer']['dependencies'][] =
'ext.eventLogging';
- $wgResourceModules['ext.multimediaViewer']['dependencies'][] =
'schema.MediaViewer';
+ if ( isset( $wgResourceModules['ext.eventLogging'] ) ) {
+ $wgResourceModules['schema.MediaViewer'] = array(
+ 'class' => 'ResourceLoaderSchemaModule',
+ 'schema' => 'MediaViewer',
+ 'revision' => 6055641,
+ );
+
+ $wgResourceModules['ext.multimediaViewer']['dependencies'][] =
'ext.eventLogging';
+ $wgResourceModules['ext.multimediaViewer']['dependencies'][] =
'schema.MediaViewer';
+ }
}
+$wgExtensionFunctions[] = 'addElDependencies';
+
$wgAutoloadClasses['MultimediaViewerHooks'] = __DIR__ .
'/MultimediaViewerHooks.php';
$wgHooks['GetBetaFeaturePreferences'][] =
'MultimediaViewerHooks::getBetaPreferences';
$wgHooks['BeforePageDisplay'][] = 'MultimediaViewerHooks::getModules';
--
To view, visit https://gerrit.wikimedia.org/r/92034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a11d13d8c0742106ce4dda15b6b3caaa6489421
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
