jenkins-bot has submitted this change and it was merged.
Change subject: Show loader whilst lazy loading geonotahack
......................................................................
Show loader whilst lazy loading geonotahack
Change-Id: I6506fbd2232acd75400688eb1e4be1461d834f5b
(cherry picked from commit b757e7a6520ac7d75bc76549b05ee906b0fd7db8)
---
M javascripts/modules/nearbypages.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/nearbypages.js
b/javascripts/modules/nearbypages.js
index 6465bd5..4ee0438 100644
--- a/javascripts/modules/nearbypages.js
+++ b/javascripts/modules/nearbypages.js
@@ -1,16 +1,20 @@
( function( M, $ ) {
var latLng, lat, lng,
MobileWebClickTracking = M.require(
'loggingSchemas/MobileWebClickTracking' ),
+ LoadingOverlay = M.require( 'LoadingOverlay' ),
+ loader = new LoadingOverlay(),
overlay;
function initNearbyButton( title, latitude, longitude ) {
function loadGeoNotAHack() {
+ loader.show();
mw.loader.using( 'mobile.nearby.beta', function() {
var NearbyOverlay = M.require(
'modules/nearby/NearbyOverlay' );
if ( !overlay ) {
MobileWebClickTracking.log(
'geonotahack-clicked' );
overlay = new NearbyOverlay( { title:
title, latitude: latitude, longitude: longitude, source: 'geonotahack' } );
}
+ loader.hide();
overlay.show();
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/92001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6506fbd2232acd75400688eb1e4be1461d834f5b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
