Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92160
Change subject: Minor tweaks
......................................................................
Minor tweaks
Change-Id: I725e37d8bde792a65fa23374e40b07eb2512f089
---
M formats/tagcloud/TagCloud.php
1 file changed, 8 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticResultFormats
refs/changes/60/92160/1
diff --git a/formats/tagcloud/TagCloud.php b/formats/tagcloud/TagCloud.php
index f0940b0..5569f03 100644
--- a/formats/tagcloud/TagCloud.php
+++ b/formats/tagcloud/TagCloud.php
@@ -3,8 +3,10 @@
namespace SRF;
use SMW\ResultPrinter;
+use SMWDataValue;
use SMWQueryResult;
use SMWPrintRequest;
+use SMWResultArray;
use SRFUtils;
use SMWOutputs;
@@ -94,8 +96,6 @@
$this->isHTML = $this->params['widget'] !== '';
$this->isHTML = $this->params['template'] === '';
- $outputmode = SMW_OUTPUT_HTML;
-
// Register RL module
if ( in_array( $this->params['widget'], array( 'sphere',
'wordcloud' ) ) ) {
SMWOutputs::requireResource( 'ext.srf.formats.tagcloud'
);
@@ -109,13 +109,13 @@
*
* @since 1.5.3
*
- * @param SMWQueryResult $results
- * @param $outputmode
+ * @param SMWQueryResult $queryResult
+ * @param $outputMode
*
* @return array
*/
- protected function getTags( SMWQueryResult $queryResult, $outputmode ) {
- $tags = array();
+ protected function getTags( SMWQueryResult $queryResult, $outputMode ) {
+ $tags = array();
$excludetags = explode( ';', $this->params['excludetags'] );
/**
@@ -137,9 +137,9 @@
// Get the HTML for the tag content.
Pages are linked, other stuff is just plaintext.
if ( $dataValue->getTypeID() == '_wpg'
) {
$value =
$dataValue->getTitle()->getText();
- $html =
$dataValue->getLongText( $outputmode, $this->getLinker( $isSubject ) );
+ $html =
$dataValue->getLongText( $outputMode, $this->getLinker( $isSubject ) );
} else {
- $html =
$dataValue->getShortText( $outputmode, $this->getLinker( false ) );
+ $html =
$dataValue->getShortText( $outputMode, $this->getLinker( false ) );
$value = $html;
}
--
To view, visit https://gerrit.wikimedia.org/r/92160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I725e37d8bde792a65fa23374e40b07eb2512f089
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
