Jack Phoenix has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92163
Change subject: SocialProfile: fixed JS on Special:GiveGift.
......................................................................
SocialProfile: fixed JS on Special:GiveGift.
Change-Id: I9f3bfcc6fb39859608f6304db196233ecde2fd57
---
M UserGifts/SpecialGiveGift.php
M UserGifts/UserGifts.js
2 files changed, 29 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile
refs/changes/63/92163/1
diff --git a/UserGifts/SpecialGiveGift.php b/UserGifts/SpecialGiveGift.php
index b6cebac..d42c0d3 100644
--- a/UserGifts/SpecialGiveGift.php
+++ b/UserGifts/SpecialGiveGift.php
@@ -318,7 +318,7 @@
Gifts::getGiftImage( $gift['id'], 'l' )
.
'" border="0" alt="" />';
- $output .= "<div
onclick=\"selectGift({$gift['id']})\"
onmouseover=\"highlightGift({$gift['id']})\"
onmouseout=\"unHighlightGift({$gift['id']})\" id=\"give_gift_{$gift['id']}\"
class=\"g-give-all\">
+ $output .= "<div id=\"give_gift_{$gift['id']}\"
class=\"g-give-all\">
{$gift_image}
<div class=\"g-title
g-blue\">{$gift['gift_name']}</div>";
if ( $gift['gift_description'] ) {
@@ -401,7 +401,7 @@
<div class="g-buttons">
<input type="hidden" name="gift_id"
value="0" />
<input type="hidden" name="user_name"
value="' . addslashes( $this->user_name_to ) . '" />
- <input type="button"
class="site-button" value="' . $this->msg( 'g-send-gift' )->plain() . '"
size="20" onclick="sendGift()" />
+ <input type="button"
id="send-gift-button" class="site-button" value="' . $this->msg( 'g-send-gift'
)->plain() . '" size="20" />
<input type="button"
class="site-button" value="' . $this->msg( 'g-cancel' )->plain() . '" size="20"
onclick="history.go(-1)" />
</div>
</form>';
diff --git a/UserGifts/UserGifts.js b/UserGifts/UserGifts.js
index f336ea5..dab0bde 100644
--- a/UserGifts/UserGifts.js
+++ b/UserGifts/UserGifts.js
@@ -3,8 +3,8 @@
selectGift: function( id ) {
// Un-select previously selected gift
- if ( selected_gift ) {
- jQuery( '#give_gift_' + selected_gift ).removeClass(
'g-give-all-selected' );
+ if ( UserGifts.selected_gift ) {
+ jQuery( '#give_gift_' + UserGifts.selected_gift
).removeClass( 'g-give-all-selected' );
}
// Select new gift
@@ -39,7 +39,32 @@
};
jQuery( document ).ready( function() {
+ // "Select a friend" dropdown menu
jQuery( 'div.g-gift-select select' ).on( 'change', function() {
UserGifts.chooseFriend( jQuery( this ).val() );
} );
+
+ // Handlers for individual gift images
+ jQuery( 'div[id^=give_gift_]' ).on({
+ 'click': function() {
+ UserGifts.selectGift(
+ jQuery( this ).attr( 'id' ).replace(
'give_gift_', '' )
+ );
+ },
+ 'mouseout': function() {
+ UserGifts.unHighlightGift(
+ jQuery( this ).attr( 'id' ).replace(
'give_gift_', '' )
+ );
+ },
+ 'mouseover': function() {
+ UserGifts.highlightGift(
+ jQuery( this ).attr( 'id' ).replace(
'give_gift_', '' )
+ );
+ },
+ });
+
+ // "Send gift" button
+ jQuery( 'input#send-gift-button' ).on( 'click', function() {
+ UserGifts.sendGift();
+ } );
} );
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/92163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f3bfcc6fb39859608f6304db196233ecde2fd57
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SocialProfile
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
