TTO has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92263
Change subject: Stop using prettifyIP for user links
......................................................................
Stop using prettifyIP for user links
At the moment, the display of IPv6 addresses is inconsistent: almost
everywhere (e.g. user pages, top of Special:Contribs) they are displayed
in the normalised form, while in places that use Linker::userLink
(history, diffs, etc) they are displayed in a supposedly "pretty" form.
For consistency, it would be better just to stick to showing the internal
representation of IPv6 addresses everywhere in MediaWiki. It would be too
messy to switch over to pretty representations everywhere at this point.
This leaves IP::prettifyIP unused in the core code, but extensions could
still be using it...
Bug: 44161
Change-Id: Ief2e0093a16df291e8ba40e1f33d829b4d8436c5
---
M includes/Linker.php
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/92263/1
diff --git a/includes/Linker.php b/includes/Linker.php
index 23ece75..c73746d 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1098,9 +1098,6 @@
public static function userLink( $userId, $userName, $altUserName =
false ) {
if ( $userId == 0 ) {
$page = SpecialPage::getTitleFor( 'Contributions',
$userName );
- if ( $altUserName === false ) {
- $altUserName = IP::prettifyIP( $userName );
- }
} else {
$page = Title::makeTitle( NS_USER, $userName );
}
--
To view, visit https://gerrit.wikimedia.org/r/92263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief2e0093a16df291e8ba40e1f33d829b4d8436c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TTO <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
