Daniel Werner has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92310
Change subject: TODO for bug 54021, Snakview should not switch between edit
modes on its own!
......................................................................
TODO for bug 54021, Snakview should not switch between edit modes on its own!
Change-Id: I0b9341037bea80f20a9da507429292e25fce4bd0
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/10/92310/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index cce0180..7863b64 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -289,6 +289,7 @@
self._leavePropertyInput = false;
+ // TODO: (Bug 54021) Widget should not switch
between edit modes on its own!
if ( event.keyCode === $.ui.keyCode.ESCAPE ) {
self.cancelEditing();
} else if ( event.keyCode ===
$.ui.keyCode.ENTER && self.isValid() ) {
--
To view, visit https://gerrit.wikimedia.org/r/92310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b9341037bea80f20a9da507429292e25fce4bd0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
