Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92418


Change subject: [browser test] workaround for VE bug probably caused by 
https://bugzilla.wikimedia.org/show_bug.cgi?id=56274
......................................................................

[browser test] workaround for VE bug probably caused by 
https://bugzilla.wikimedia.org/show_bug.cgi?id=56274

Change-Id: I2b872966399ecb6eb60da619eb9af52ae33f3aca
---
M 
modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/18/92418/1

diff --git 
a/modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb
 
b/modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb
index 821646c..bf27fa5 100644
--- 
a/modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb
+++ 
b/modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb
@@ -4,7 +4,9 @@
 
    When(/^I type in an input string$/) do
   on(VisualEditorPage) do |page|
-    page.content_element.when_present.send_keys "This is a new line"
+    #extra space after 'line' below is a workaround for FF issue where VE is 
sending BACKSPACE before RETURN
+    #probably caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=56274
+    page.content_element.when_present.send_keys "This is a new line "
     page.content_element.when_present.send_keys :return
   end
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/92418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b872966399ecb6eb60da619eb9af52ae33f3aca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to